| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Setting pd_lower in GIN metapage |
| Date: | 2017-09-20 04:07:57 |
| Message-ID: | CAB7nPqQ0wA=iE1mpXq6DZB93UKqKg41xZB18Sn9OADHfL6g4dw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 20, 2017 at 12:49 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Sep 20, 2017 at 4:25 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> Also, _hash_init() would need some extra work to
>> generate FPWs, but I don't think that it is necessary per its handling
>> of a per-record meta data either. So REGBUF_STANDARD could be just
>> removed from there, and there is actually no need to patch
>> src/backend/access/hash at all.
>>
>
> I think there is no need to remove it. As per discussion above, we
> want to keep REGBUF_STANDARD for all metapage initializations for the
> matter of consistency and that will be useful for
> wal_consistency_checking in which case we anyway need full page image.
Arf, yes. You are indeed right. I misread that you still need that
anyway in XLogRecordAssemble.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-09-20 04:14:59 | Re: Partition-wise join for join between (declaratively) partitioned tables |
| Previous Message | Amit Kapila | 2017-09-20 04:06:50 | Re: src/test/subscription/t/002_types.pl hanging on particular environment |