| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing checks when malloc returns NULL... |
| Date: | 2016-08-30 08:11:35 |
| Message-ID: | CAB7nPqQ=tD5Op_em4ux_5SXvkOBoVMu22WvM8RDnTTH7=McbxA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 30, 2016 at 5:08 PM, Aleksander Alekseev
<a(dot)alekseev(at)postgrespro(dot)ru> wrote:
>> > The funny part here is that ProcGlobal->allProcs is actually handled,
>> > but not the two others. Well yes, you are right, we really need to
>> > fail on FATAL for all of them if ShmemAlloc returns NULL as they
>> > involve the shmem initialization at postmaster startup.
>>
>> And with an actual patch things are better.
>
> Currently I can't think of any further improvements. I even would dare
> to say that patch is Ready for Committer.
Thanks for the fruitful input by the way! You spotted many things.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2016-08-30 08:21:42 | Re: Missing checks when malloc returns NULL... |
| Previous Message | Aleksander Alekseev | 2016-08-30 08:08:49 | Re: Missing checks when malloc returns NULL... |