| From: | Hubert Zhang <hzhang(at)pivotal(dot)io> |
|---|---|
| To: | Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Gang Xiong <gxiong(at)pivotal(dot)io>, Asim R P <apraveen(at)pivotal(dot)io>, Ning Yu <nyu(at)pivotal(dot)io> |
| Subject: | Re: Yet another vectorized engine |
| Date: | 2020-02-27 08:09:05 |
| Message-ID: | CAB0yremLN1ATVT7cvUXeAD9W=VXGMq9iSyF1QPRUfQ-McDmAsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Konstantin,
I also vimdiff nodeAgg.c in your PG13 branch with nodeAgg.c in pg's main
repo.
Many functions has changed from PG96 to PG13, e.g. 'advance_aggregates',
'lookup_hash_entry'
The vectorized nodeAgg seems still follow the PG96 way of implementing
these functions.
In general, I think we'd better port executor of PG13 to vectorized
executor of PG13 instead of merge some PG13 code into vectorized executor
of PG96 to make it works. Because It's hard to determine which functions
need to be merged and it's buggy if the executor code of both PG13 and PG96
exist in one branch.
What's your opinion?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-02-27 08:23:46 | Improve handling of parameter differences in physical replication |
| Previous Message | Julien Rouhaud | 2020-02-27 08:07:35 | Re: reindex concurrently and two toast indexes |