Re: Reviewers needed for pgjdbc pull requests

From: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
To: Sehrope Sarkuni <sehrope(at)jackdb(dot)com>
Cc: Robert Zenz <robert(dot)zenz(at)sibvisions(dot)com>, "pgsql-jdbc(at)lists(dot)postgresql(dot)org" <pgsql-jdbc(at)lists(dot)postgresql(dot)org>
Subject: Re: Reviewers needed for pgjdbc pull requests
Date: 2018-05-15 14:45:23
Message-ID: CAB=Je-HK8O+c1r_1BCDD3bm33A=89=_PCdv6LH1akOXtnMoZBQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

"looks good to me" looks good to me.

From my point of view, the following review items are hard to verify
automatically:
missing test cases
backward compatibility.

Of course, it is not trivial to have 100% cases covered, so sometimes I
just try to check how the code plays against corner cases.

Vladimir

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message John Bester 2018-05-16 13:02:09 JDBC problem in 10.3 / 10.4
Previous Message Sehrope Sarkuni 2018-05-15 14:27:31 Re: Reviewers needed for pgjdbc pull requests