Re: Wrong link not pointing to the release tarball

From: Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>
To: Pavel Raiskup <praiskup(at)redhat(dot)com>
Cc: Dave Cramer <pg(at)fastcrypt(dot)com>, List <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: Wrong link not pointing to the release tarball
Date: 2016-01-22 14:30:59
Message-ID: CAB=Je-FUbxj==Rm8x7uRy+A=SgBsaunyB16DRgx0ma_Y5p2qvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

>[1] http://pkgs.fedoraproject.org/cgit/rpms/postgresql-jdbc.git/tree/postgresql-jdbc.spec

>37: Version: 9.4.%{upstreamrel}

It should be %{upstreamver}, shouldn't it?

># ASL 2.0 applies only to postgresql-jdbc.pom file, the rest is BSD
>License: BSD and ASL 2.0

That is strange. Which "postgresql-jdbc.pom" is referred to here?

> 57: BuildRequires: ant
> 58: BuildRequires: ant-junit

I do not think we require ant.

>85: find -name "*.jar" -or -name "*.class" | xargs rm -f

We have *.class files for a good reason: they include gettext translations.
If you absolutely require to kill that, you need to add "mvn
-Ptranslate compile" step to perform "gettext" step.
However, that would void "built from the same git source" statement.

>111: ln -s postgresql-jdbc.jar postgresql-jdbc2.jar

That is somewhat risky, since the new jar is not usable for old JRE.
In other words, if a software exists that uses Java 5 and jdbc2.jar,
then newly build jar is not compatible with it.

In order to build jre7, and jre6-compatible jars, separate build steps
should be used.
We have https://github.com/pgjdbc/pgjdbc-jre7 & jre6 for that.

Vladimir

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Dave Cramer 2016-01-22 14:37:24 Re: Wrong link not pointing to the release tarball
Previous Message Pavel Raiskup 2016-01-22 14:17:50 Re: Wrong link not pointing to the release tarball