From: | Joseph Koshakow <koshy44(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Fix overflow hazard in interval rounding |
Date: | 2024-06-02 23:01:15 |
Message-ID: | CAAvxfHe3TMuSeFvrFKzKVb6nxr3Cg27fk3R5W=Y1HPAGs1vHqA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Andres,
Sorry for such a late reply.
On Tue, Feb 13, 2024 at 2:14 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Random, mildly related thought: I wonder if it's time to, again, look at
> enabling -ftrapv in assert enabled builds.I had looked at that a few years
> back, and fixed a number of instances, but not all I think. But I think
we are
> a lot closer to avoiding signed overflows everywhere, and it'd be nice to
find
> overflow hazards more easily.
I agree that this would be very helpful.
> Many places are broken even with -fwrapv
> semantics (which we don't have on all compilers!). Trapping on such
overflows
> makes it far easier to find problems with tools like sqlsmith.
Does this mean that some of our existing tests will panic when compiled
with -ftrapv or -fwrapv? If so I'd be interested in resolving the
remaining issues if you could point me in the right direction of how to
set the flag.
Thanks,
Joe Koshakow
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2024-06-02 23:57:40 | Re: Improve the connection failure error messages |
Previous Message | Tom Lane | 2024-06-02 22:15:48 | Re: pltcl crashes due to a syntax error |