Re: Remove dependence on integer wrapping

From: Joseph Koshakow <koshy44(at)gmail(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: Remove dependence on integer wrapping
Date: 2024-06-19 21:44:00
Message-ID: CAAvxfHdze21+UZPWo7ePfH19-9hvXe_9SEZk4HABPHuzaUitRQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 13, 2024 at 10:56 PM Joseph Koshakow <koshy44(at)gmail(dot)com> wrote:

On Thu, Jun 13, 2024 at 10:48 PM Joseph Koshakow <koshy44(at)gmail(dot)com>
wrote:
> I've attached
> v4-0002-Handle-overflow-in-money-arithmetic.patch which adds some
> overflow checks and tests. I didn't address the float
multiplication
> because I didn't see any helper methods in int.h. I did some some
> useful helpers in float.h, but they raise an error directly instead
> of returning a bool. Would those be appropriate for use with the
> money type? If not I can refactor out the inner parts into a new
method
> that returns a bool.

> v4-0001-Remove-dependence-on-integer-wrapping.patch is unchanged, I
> just incremented the version number.

I added overflow handling for float arithmetic to the `money` type.
v6-0002-Handle-overflow-in-money-arithmetic.patch is ready for review.

v6-0001-Remove-dependence-on-integer-wrapping.patch is unchanged, I
just incremented the version number.

Thanks,
Joe Koshakow

Attachment Content-Type Size
v6-0001-Remove-dependence-on-integer-wrapping.patch text/x-patch 13.5 KB
v6-0002-Handle-overflow-in-money-arithmetic.patch text/x-patch 11.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2024-06-19 21:53:54 Re: IPC::Run accepts bug reports
Previous Message Nathan Bossart 2024-06-19 21:14:10 Re: fix pg_upgrade comment