Re: Patch to allow domains over composite types

From: Asif Rehman <asifalirehman(at)gmail(dot)com>
To: Yeb Havinga <yebhavinga(at)gmail(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to allow domains over composite types
Date: 2012-02-27 11:49:52
Message-ID: CAAuGLxU7BxNtTR7187-znBFacD=kbWBOETKswY+uJx=DFewVkA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Yeb Havinga,

I was digging archives to see anyone worked on supporting domain's over
composite type and found your patch, but that was pulled back. According to
commitfest comments it needs some more work...

Are you going to submit the updated patch?

Regards,
--Asif

On Wed, May 11, 2011 at 5:07 PM, Yeb Havinga <yebhavinga(at)gmail(dot)com> wrote:

> typecmds.c says:
> "Domains over composite types might be made to work in the future, but not
> today."
>
> Attached is a patch that allows domains over composite types, together
> with test cases in domaincomp.sql. A domain over a composite type has
> typtype TYPTYPE_DOMAIN, but typrelid and typrelkind are empty: that
> information is only available in the pg_type record of the base type. The
> remainder of the patch follows from that choice. While parsing a record
> expression into a row type, an extra coercion node had to be inserted to
> ensure that the domain checks are called.
>
> All regression tests are ok, comments are highly appreciated.
>
> --
>
> Yeb Havinga
> http://www.mgrid.net/
> Mastering Medical Data
>
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2012-02-27 11:55:20 Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.
Previous Message Marti Raudsepp 2012-02-27 10:45:38 [PATCH] Cleanup: use heap_open/heap_close consistently