Re: pgAdmin 4 commit: Add support for detachable tabs to the runtime.

From: Robert Eckhardt <reckhardt(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Add support for detachable tabs to the runtime.
Date: 2017-06-16 12:47:41
Message-ID: CAAtBm9V5s2j0Qc4Y6kXZ=C4W_TStQ8aZCTyMTYsStBUSpbxPkQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Nice! This is awesome. I didn't see it land.

-- Rob

On Fri, Jun 16, 2017 at 1:57 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Add support for detachable tabs to the runtime.
>
> This allows the Query Tool, Debugger and web browser tabs to be moved to
> different monitors as desired.
>
> Fixes #1344
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 0056a94115416c12690f58af3b77b9ce7c02da95
> Author: Neel Patel <neel(dot)patel(at)enterprisedb(dot)com>
>
> Modified Files
> --------------
> runtime/BrowserWindow.cpp | 337 +++++++++++++---------------
> runtime/BrowserWindow.h | 15 +-
> runtime/TabWindow.cpp | 542 ++++++++++++++++++++++++++++++
> +++++++++++++---
> runtime/TabWindow.h | 151 ++++++++++++-
> runtime/WebViewWindow.cpp | 82 +++++++
> runtime/WebViewWindow.h | 17 +-
> runtime/back.png | Bin 448 -> 290 bytes
> runtime/close.png | Bin 587 -> 346 bytes
> runtime/forward.png | Bin 445 -> 270 bytes
> runtime/pgAdmin4.cpp | 15 +-
> runtime/pgAdmin4.qrc | 1 +
> runtime/qss/pgadmin4.qss | 3 +
> 12 files changed, 937 insertions(+), 226 deletions(-)
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-06-16 13:00:27 Re: Migrating this list to PGLister on Friday, June 16th, 1300 UTC
Previous Message pgAdmin 4 Jenkins 2017-06-16 11:12:56 Jenkins build is back to normal : pgadmin4-master-python27 #185