| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, postgresql(dot)wizard(at)gmail(dot)com |
| Subject: | Re: Add missing tab completion for VACUUM and ANALYZE with ONLY option |
| Date: | 2025-03-19 12:41:51 |
| Message-ID: | CAApHDvrxY+vqSi_wnpqfa7NrGXjm+01rJC4sZiy3_nS3QkQXGw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 19 Mar 2025 at 23:22, Ilia Evdokimov
<ilya(dot)evdokimov(at)tantorlabs(dot)com> wrote:
> Everything seems fine with the ANALYZE command autocompletion. Regarding VACUUM, I'm not entirely convinced we should provide autocompletion in every case. I'd prefer to keep the behavior from the v3 patch because the original intention behind adding the ONLY keyword was specifically for collecting statistics exclusively from parent tables. Therefore, autocompletion makes sense primarily for the ANALYZE case.
While VACUUM ONLY on a partitioned table has no effect, the same isn't
true for inheritance parents. 62ddf7ee9 did change the behaviour of
VACUUM for these so that vacuuming the inheritance parent now vacuums
all of its children, unless ONLY is used. So, I'd say if the tab
completion is only added to ANALYZE, then it'd be incomplete still.
(I've not looked at the v3 patch to see which of those it handles.)
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-03-19 12:46:10 | Re: Update Unicode data to Unicode 16.0.0 |
| Previous Message | Andrew Dunstan | 2025-03-19 12:28:44 | Re: Add -k/--link option to pg_combinebackup |