| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fixup some appendStringInfo and appendPQExpBuffer calls |
| Date: | 2021-06-04 10:53:58 |
| Message-ID: | CAApHDvrxNTJw7VfAvf0vFkLPQApr1yWX0Rxw6GMKo=o=5MLZHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 3 Jun 2021 at 16:17, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > There are quite a few other places in that file that should be using
> > DatumGetCString() instead of DatumGetPointer().
> > Should we fix those too for PG14?
>
> +1. I'm surprised we are not getting compiler warnings.
I pushed a fix for this.
I did happen to find one other in mcv.c which dates back to 2019. I
was wondering if we should bother with that one since it's already out
there in PG13.
David
| Attachment | Content-Type | Size |
|---|---|---|
| use_OutputFunctionCall_in_mcv.c.patch | application/octet-stream | 804 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-06-04 11:08:38 | Re: Transactions involving multiple postgres foreign servers, take 2 |
| Previous Message | Etsuro Fujita | 2021-06-04 10:26:05 | Re: Asynchronous Append on postgres_fdw nodes. |