From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, 謝東霖 <douenergy(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Improve join_search_one_level readibilty (one line change) |
Date: | 2023-08-06 09:55:18 |
Message-ID: | CAApHDvrvO724r32LRW-GS6UVqFNO7FXDHcNM3UZd+4hagKZBxQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 4 Aug 2023 at 16:05, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
>
> On Fri, Aug 4, 2023 at 10:36 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>>
>> The whole lnext() stuff all feels a bit old now that Lists are arrays.
>> I think we'd be better adjusting the code to pass the List index where
>> we start from rather than the ListCell to start from. That way we can
>> use for_each_from() to iterate rather than for_each_cell(). What's
>> there today feels a bit crufty and there's some element of danger that
>> the given ListCell does not even belong to the given List.
>
>
> I think we can go even further to do the same for 'bushy plans' case,
> like the attached.
Seems like a good idea to me. I've pushed that patch.
Alex, many thanks for highlighting this and posting a patch to fix it.
Congratulations on your first patch being committed.
David
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2023-08-06 12:31:36 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |
Previous Message | Julien Rouhaud | 2023-08-06 07:25:23 | Re: How to add a new operator for parser? |