Re: Surely this code in setrefs.c is wrong?

On Sun, 10 Sept 2023 at 21:07, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Sun, 10 Sept 2023 at 11:22, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > if (!OidIsValid(saop->hashfuncid))
> > record_plan_function_dependency(root, saop->hashfuncid);
> >
> > if (!OidIsValid(saop->negfuncid))
> > record_plan_function_dependency(root, saop->negfuncid);
> >
> > Surely those if-conditions are exactly backward, and we should be
> > recording nonzero hashfuncid and negfuncid entries, not zero ones.
>

> I'll push fixes once the 16.0 release is out of the way.

Fixed in ee3a551e9.

David