| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reducing the chunk header sizes on all memory context types |
| Date: | 2022-08-30 03:21:49 |
| Message-ID: | CAApHDvrtrFHN06_NK1rJwtKYG_mwcNLPn-yyj2eD_RvaNTVong@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 30 Aug 2022 at 15:15, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> AFAICS that could only happen if "double" has 8-byte alignment
> requirement but int64 does not. I recall some discussion about
> that possibility a month or two back, but I think we concluded
> that we weren't going to support it.
ok
> I guess what I mostly don't like about df0f4feef is the hardwired "8"
> constants. Yeah, it's hard to see how sizeof(uint64) isn't 8, but
> it's not very readable like this IMO.
Yeah, that was just down to lack of any SIZEOF_* macro to tell me
uint64 was 8 bytes.
I can revert df0f4feef, but would prefer just to get the green light
for d5ee4db0e from those 32-bit arm animals before doing so.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-30 03:31:11 | Re: Reducing the chunk header sizes on all memory context types |
| Previous Message | Richard Guo | 2022-08-30 03:21:42 | Re: Making Vars outer-join aware |