| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, xinwen(at)stu(dot)scu(dot)edu(dot)cn, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17777: An assert failed in nodeWindowAgg.c |
| Date: | 2023-02-13 05:29:46 |
| Message-ID: | CAApHDvrrxPy3_R7qi6Hy3cyUhPFvLJWppo0GBFJMjyFpqCyWsA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, 13 Feb 2023 at 13:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Code looks good now, but the comment still claims this is only
> important in the FILTER clause. I'd rewrite the whole thing
> perhaps:
>
> * We also don't risk using moving aggregates when there are subplans
> * in the arguments or FILTER clause. This is partly because
> * contain_volatile_functions() doesn't look inside subplans; but
> * there are other reasons why a subplan's output might be volatile.
> * For example, syncscan mode can render the results nonrepeatable.
That seems better, so I pushed it with that. Thanks.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-02-13 05:30:02 | Re: BUG #17777: An assert failed in nodeWindowAgg.c |
| Previous Message | Fujii Masao | 2023-02-13 05:29:09 | array_agg(DISTINCT) caused a segmentation fault |