Re: Missed TidRangePath in the print_path switch

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Missed TidRangePath in the print_path switch
Date: 2023-09-28 10:33:14
Message-ID: CAApHDvrmKo+ectDSF8+grdp+meDod+sPJA2h_6_BxOJATPN=0g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, 28 Sept 2023 at 18:07, Andrey Lepikhov
<a(dot)lepikhov(at)postgrespro(dot)ru> wrote:
> The TidRangePath node was introduced three years ago. However, path
> printing machinery still does not support it. It isn't enjoyable to add
> this string of code each time. I suggest adding it now.
> Also, I propose not printing "???path" in the default case but throwing
> a warning - see the patch in the attachment. It can help to avoid such
> slip-ups next time.
> It generally makes sense to generate such long switches automatically,
> likewise nodeToString.

Thanks for the report and patch.

I'll push the fix shortly. I'll leave off the WARNING thing for now.
Perhaps an Assert would draw more attention to the correct people. We
can debate that later as a master only change.

David

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Vik Fearing 2023-09-28 11:28:35 Re: Broken type checking for empty subqueries
Previous Message Marek Malevič 2023-09-28 09:08:15 Broken type checking for empty subqueries