| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Outdated comment in get_agg_clause_costs |
| Date: | 2021-07-26 02:58:39 |
| Message-ID: | CAApHDvrk7xEpjX=V=dfUD1JXb+DO5QN6e+jNFUBUmqt80Ws1AQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 23 Jul 2021 at 02:29, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I've attached a patch that adjusts the comment so it's more aligned to
> what it now does.
This was a bit more outdated than I first thought. I also removed the
mention of the function setting the aggtranstype and what it mentions
about also gathering up "counts". I assume that was related to
numOrderedAggs which is now done in preprocess_aggref().
I ended up pushing to master and PG14. The code was new to PG14 so I
thought it made sense to keep master and 14 the same since 14 is not
yet out the door.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-07-26 02:58:42 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Greg Nancarrow | 2021-07-26 02:47:50 | Re: Added schema level support for publication. |