Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, Ivan Bykov <I(dot)Bykov(at)modernsys(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
Date: 2025-03-24 06:42:21
Message-ID: CAApHDvrhM=ZZRgMkf7YFhHZbn+Vm4iL+BWB0U8kTA1ryCuH65A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 24 Mar 2025 at 15:23, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> And here we get 18564.06 (head) vs 16667.92 (patch) so a 10.7%
> difference in this run. Hence the automatic addition of NULL to the
> jumbling is disappointing here, even if this is what I'd see this as a
> worst case scenario, unlikely what one would see for real if they care
> about monitoring.

Can you share which patch you tested here? There are many patches on
this thread and I don't want to make assumptions about which one these
are the results for.

It sounds like it wasn't your latest patch as you mentioned "automatic
addition of NULL to the jumbling". That doesn't sound like the
correct description for your latest patch.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tender Wang 2025-03-24 06:50:08 Re: Add mention in docs about locking all partitions for generic plans
Previous Message David Rowley 2025-03-24 06:33:48 Re: Patch: Cover POSITION(bytea,bytea) with tests