Re: shadow variables - pg15 edition

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>
Subject: Re: shadow variables - pg15 edition
Date: 2022-08-25 14:56:15
Message-ID: CAApHDvrgMWgPKEaby0R2Jnf3BhRdtdH3ysa1cVyBmZ7t8xWvvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 25 Aug 2022 at 13:46, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I've attached a patch which I think improves the code in
> gistRelocateBuildBuffersOnSplit() so that there's no longer a shadowed
> variable. I also benchmarked this method in a tight loop and can
> measure no performance change from getting the loop index this way vs
> the old way.

I've now pushed this patch too.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-08-25 15:04:35 Re: pg_regress: lookup shellprog in $PATH
Previous Message David Rowley 2022-08-25 14:55:42 Re: shadow variables - pg15 edition