Re: [PATCH] Negative Transition Aggregate Functions (WIP)

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Date: 2014-01-02 12:05:34
Message-ID: CAApHDvrabeMqgEa1u-dx0yv04SftH_fQBB+N6qvhDLm2KiJA0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 27, 2013 at 1:36 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:

> From what I can tell adding an inverse transition function to support AVG
> for numeric does not affect the number of trailing zeros in the results, so
> I've attached a patch which now has inverse transition functions to support
> numeric types in AVG and all of the STDDEV* aggregates.
>

here's a slightly updated patch in which I've fixed up an comment that had
become out-dated because of the patch. I also changed the wording in quite
a few of my comments and made some changes to the docs. The only other
change was an extra error check just in case window_gettupleslot was to
fail to get a tuple that should always be in the tuple store.

I'm now classing the patch is not WIP anymore. I think it's ready for the
commitfest.

Regards

David Rowley

Attachment Content-Type Size
inverse_transition_functions_v1.8.patch.gz application/x-gzip 19.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2014-01-02 12:21:17 [PATCH] Remove some duplicate if conditions
Previous Message Christian Kruse 2014-01-02 11:08:37 Re: Patch: show relation and tuple infos of a lock to acquire