Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposals for EXPLAIN: rename ANALYZE to EXECUTE and extend VERBOSE
Date: 2024-11-06 00:23:26
Message-ID: CAApHDvrYwEt=ueMTn39okNihZffhKgqvxedLqDJu=hmSsZ=g9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 6 Nov 2024 at 12:33, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> The main premise here is that explain should include buffers by default, and to do so we are willing to inconvenience testers who do not want buffer data in their test plans to have to modify their tests to explicitly exclude buffers. We'll have to eat our own dog food here and go and add "buffers off" throughout our code base to make this happen. I personally feel that we should accept a patch that does so. The benefits to the many outweigh the one-time inconveniencing of the few. Especially if limited to explain analyze.

I'm not against analyze = on turning buffers on by default. However, I
think it would be quite painful to fix the tests if it were on without
analyze.

I tried it to see just how extensive the changes would need to be.
It's not too bad. partition_prune.sql is the worst hit.

23 files changed, 171 insertions(+), 166 deletions(-)

David

Attachment Content-Type Size
explain_buffers_by_default.patch text/plain 73.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-11-06 00:28:35 Re: Rename Function: pg_postmaster_start_time
Previous Message Michael Paquier 2024-11-06 00:19:54 Re: define pg_structiszero(addr, s, r)