Re: SupportRequestRows support function for generate_series_timestamptz

On Mon, 8 Jul 2024 at 16:43, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> { oid => '2031',
> proname => 'timestamp_mi', prorettype => 'interval',
> proargtypes => 'timestamp timestamp', prosrc => 'timestamp_mi' },
> { oid => '1188',
> proname => 'timestamptz_mi', prorettype => 'interval',
> proargtypes => 'timestamptz timestamptz', prosrc => 'timestamp_mi' },

I'm not quite sure what you mean that needs to be adjusted with this.

> so this also apply to
>
> { oid => '938', descr => 'non-persistent series generator',
> proname => 'generate_series', prorows => '1000', proretset => 't',
> prorettype => 'timestamp', proargtypes => 'timestamp timestamp interval',
> prosrc => 'generate_series_timestamp' },
>
> If so, then we need to update src/include/catalog/pg_proc.dat also?

Oh, yeah. I missed setting the prosupport function for that one. Thanks.

I'm not sure when I realised there were 3 of these functions, but it
seems I didn't when I adjusted pg_proc.dat.

Updated patch attached.

David