| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Andrei Lepikhov <lepihov(at)gmail(dot)com>, Zhang Mingli <zmlpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove useless GROUP BY columns considering unique index |
| Date: | 2024-12-12 02:55:53 |
| Message-ID: | CAApHDvrHyz5LjZnwbEYsfbixbrK5H7+hwHd=et1vrX6iMeyf3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2 Dec 2024 at 17:22, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> regarding v10.
> you placed remove_useless_groupby_columns right after add_base_rels_to_query
> makes so much sense.
> so we can be safely use cached RelOptInfo->indexlist, RelOptInfo->notnullattnums
> overall it didn't find any issue.
Thanks for looking.
After a bit more adjustment, I've pushed both patches.
I felt it was best to have the commit that moved
remove_useless_groupby_columns also change the call site of that
function.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-12-12 03:09:44 | Re: Remove useless GROUP BY columns considering unique index |
| Previous Message | jian he | 2024-12-12 02:47:47 | Re: not null constraints, again |