| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Revert: Remove useless self-joins *and* -DREALLOCATE_BITMAPSETS make server crash, regress test fail. |
| Date: | 2024-05-07 05:46:12 |
| Message-ID: | CAApHDvrG5rE-hvoucXCmM4fRwQhZRZYvtB3rCk6g5BmsWv6mQg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 7 May 2024 at 17:28, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > Yeah, before the revert, that did:
> > - sjinf->syn_lefthand = replace_relid(sjinf->syn_lefthand, relid, subst);
> > That replace code seems to have always done a bms_copy()
>
> Hmm, not always; see e0477837c.
It was the discussion on that thread that led to the invention of
REALLOCATE_BITMAPSETS
> What I'm trying to figure out here is whether we have a live bug
> in this area in released branches; and if so, why we've not seen
> reports of that.
We could check what portions of REALLOCATE_BITMAPSETS are
backpatchable. It may not be applicable very far back because of v16's
00b41463c. The bms_del_member() would have left a zero set rather than
doing bms_free() prior to that commit. There could be a bug in v16.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-05-07 06:01:46 | Re: Use pgstat_kind_infos to read fixed shared stats structs |
| Previous Message | Tristan Partin | 2024-05-07 05:44:51 | Re: Use pgstat_kind_infos to read fixed shared stats structs |