Re: MERGE/SPLIT partition commands should create new partitions in the parent's tablespace?

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: MERGE/SPLIT partition commands should create new partitions in the parent's tablespace?
Date: 2024-07-10 09:58:25
Message-ID: CAApHDvrDeYerR9eKHE0HVfon39VcRBu9do+dov1QsRPMwejBgQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, 6 Jul 2024 at 19:06, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> I noticed that ALTER TABLE MERGE PARTITIONS and SPLIT PARTITION commands
> always create new partitions in the default tablespace, regardless of
> the parent's tablespace. However, the indexes of these new partitions inherit
> the tablespaces of their parent indexes. This inconsistency seems odd.
> Is this an oversight or intentional?

My expectation of this feature is that the tablespace choice would
work the same as what was done in ca4103025 to make it inherit from
the partition table's tablespace. I imagine we might get complaints if
it does not follow the same logic.

I've not looked at your patch, but if the behaviour is as you describe
and the patch changes that to follow ca4103025, then +1 from me.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-07-10 10:57:53 Re: Lock-free compaction. Why not?
Previous Message Dave Page 2024-07-10 09:55:50 Re: Should we work around msvc failing to compile tab-complete.c?