| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Improve PQtrace() output format |
| Date: | 2021-04-06 06:35:15 |
| Message-ID: | CAApHDvrCReKezLJa1TFpbdyhRkz09j2Yib3Pro5XkdAOiVHJfg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, 6 Apr 2021 at 17:21, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
> > As best I can tell from these warnings, VS has the tv_sec field
> > of struct timeval defined as something other than time_t. Because
> > VS would never stoop to actually complying with the plain text of
> > the POSIX standard.
>
> Ah, seems like it's really Winsock's fault:
>
> https://docs.microsoft.com/en-us/windows/win32/api/winsock/ns-winsock-timeval
Yeah. Thanks for having a look. I pushed the fix with a comment
explaining why we bother with the local variable.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-04-06 08:42:52 | Re: pgsql: Allow pgoutput to send logical decoding messages. |
| Previous Message | David Rowley | 2021-04-06 06:34:01 | pgsql: Fix compiler warning in fe-trace.c for MSVC |