Re: Fixing Hash Join bug I caused with adf97c156

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Fixing Hash Join bug I caused with adf97c156
Date: 2024-10-16 02:21:44
Message-ID: CAApHDvrBt_f4AL_s7zquhq9MrDNvXS0Auw8CGbfj_nUnP20NEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 16 Oct 2024 at 14:22, Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru> wrote:
> I haven't noticed anything wrong yet. I think it's worth adding a test
> to regression tests, isn't it?

Here's a patch including a test this time.

I had imagined that it would be hard to make the same mistake again...

David

Attachment Content-Type Size
v1-0001-Don-t-store-intermediate-hash-values-in-ExprState.patch application/octet-stream 11.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2024-10-16 03:00:00 Re: ECPG cleanup and fix for clang compile-time problem
Previous Message David G. Johnston 2024-10-16 01:46:44 Re: Doc: shared_memory_size_in_huge_pages with the "SHOW" command.