Re: shadow variables - pg15 edition

On Thu, 6 Oct 2022 at 03:19, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > I've attached a draft patch for a method I was considering to fix the
> > warnings we're getting from the nested PG_TRY() statement in
> > utility.c.
>
> +1

Pushed.

> > The only warning remaining after applying the attached is the "now"
> > warning in pgbench.c:7509. I'd considered changing this to "thenow"
> > which translates to "right now" in the part of Scotland that I'm from.
> > I also considered "nownow", which is used in South Africa [1].
> > Anyway, I'm not really being serious, but I didn't come up with
> > anything better than "now2".
>
> Yeah, "now2" seems as reasonable as anything.

Also pushed. (Thanks for saving me on that one.)

David