| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "dpage(at)pgadmin(dot)org" <dpage(at)pgadmin(dot)org>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "bruce(at)momjian(dot)us" <bruce(at)momjian(dot)us>, "vik(at)postgresfriends(dot)org" <vik(at)postgresfriends(dot)org> |
| Subject: | Re: [16Beta1][doc] pgstat: Track time of the last scan of a relation |
| Date: | 2023-05-31 06:13:57 |
| Message-ID: | CAApHDvr2WOUdnvJemheTXtONC6KdWrBwSxLCN8b687+vLFbKyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 31 May 2023 at 15:57, Shinoda, Noriyoshi (PN Japan FSIP)
<noriyoshi(dot)shinoda(at)hpe(dot)com> wrote:
> According to the documentation [2], the data type of the columns added to these views is 'timestamptz'.
> However, columns of the same data type in pg_stat_all_tables.last_vacuum, last_analyze and other tables are unified to 'timestamp with time zone'. The attached patch changes the data type of the added column from timestamptz to timestamp with time zone.
I agree that it would be good to make those consistently use timestamp
with time zone for all columns of that type in the docs for
pg_stat_all_tables.
More generally, it might be good if we did it for the entire docs:
doc $ git grep "<type>timestamptz</type>" | wc -l
17
doc $ git grep "<type>timestamp with time zone</type>" | wc -l
74
Clearly "timestamp with time zone" is much more commonly used.
The bar is probably set a bit higher for changing the
longer-established ones, however.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-05-31 06:36:45 | Re: ERROR: wrong varnullingrels (b 3) (expected (b)) for Var 2/1 |
| Previous Message | David Rowley | 2023-05-31 06:03:01 | Re: PG 16 draft release notes ready |