| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Arne Roland <A(dot)Roland(at)index(dot)de> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Amit Langote <amitlangote09(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Subject: | Re: missing indexes in indexlist with partitioned tables |
| Date: | 2023-01-09 04:21:09 |
| Message-ID: | CAApHDvr+mdLD7WqiMJiAV4dH37x+ho+vYu1ETdfRccyXUGOPVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 6 Dec 2022 at 13:43, Arne Roland <A(dot)Roland(at)index(dot)de> wrote:
> That being said, attached patch should fix the issue reported below.
I took a look over the v10 patch and ended up making adjustments to
the tests. I didn't quite see the need for the test to be as extensive
as you had them in v10. Neither join removals nor unique joins treat
partitioned tables any differently from normal tables, so I think it's
fine just to have a single test that makes sure join removals work on
partitioned tables. I didn't feel inclined to add a test for unique
joins. The test I added is mainly just there to make sure something
fails if someone decides partitioned tables don't need the indexlist
populated at some point in the future.
The other changes I made were just cosmetic. I pushed the result.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-01-09 05:03:44 | Re: Logical replication timeout problem |
| Previous Message | Andrey Borodin | 2023-01-09 04:19:14 | Re: MultiXact\SLRU buffers configuration |