Re: pgsql: Flush Memoize cache when non-key parameters change

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: David Rowley <drowley(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Flush Memoize cache when non-key parameters change
Date: 2021-11-24 09:54:08
Message-ID: CAApHDvqvmPM5LfZByNhh=WpuOxDSZ0dmXMQeaA8HPf=H6ndJOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, 24 Nov 2021 at 20:27, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Wed, 24 Nov 2021 at 17:31, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > From what I can see, there are two separate problems here:
> > - force_parallel_mode = regress.
> > - -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE.
>
> Thanks. I missed adding keyparamids to the copy/read/write functions.

Looks like the cause of the animals that had the plan change [1][2] is
a timing issue where tenk2 is not auto-analyzed before the Memoize
test. Due to the lack of stats, Memoize is not considered in the
planner.

I see tenk1 is manually ANALYZEd, so I'll just change the tests to use
tenk1 instead of tenk2.

David

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=serinus&dt=2021-11-24%2002%3A04%3A18
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=flaviventris&dt=2021-11-24%2002%3A24%3A03

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2021-11-24 10:29:40 pgsql: Flush Memoize cache when non-key parameters change, take 2
Previous Message David Rowley 2021-11-24 07:27:50 Re: pgsql: Flush Memoize cache when non-key parameters change