Re: Fixup some StringInfo usages

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixup some StringInfo usages
Date: 2024-04-09 23:57:20
Message-ID: CAApHDvquo32SBhb5aNDzPCgWO3BOOd62fF0ROLCH7Sdp85c7ig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 9 Apr 2024 at 14:27, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > Similar to f736e188c, I've attached a patch that fixes up a few
> > misusages of the StringInfo functions. These just swap one function
> > call for another function that is more suited to the use case.
>
> > I feel like it's a good idea to fix these soon while they're new
> > rather than wait N years and make backpatching bug fixes possibly
> > harder.
>
> +1. Looks good in a quick eyeball scan.

Thank you to both of you for having a look. Pushed.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-04-09 23:58:04 Re: "an SQL" vs. "a SQL"
Previous Message Michael Paquier 2024-04-09 23:50:56 Re: post-freeze damage control