| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path |
| Date: | 2020-11-23 20:36:55 |
| Message-ID: | CAApHDvqtRa3B0Op5LVY7cDkXaKQex6iFipEcHKx3Kj8hxSuogQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 21 Nov 2020 at 03:26, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> I did tests of elog_ereport_attribute_cold_v4.patch on an oldish Mac
> Intel laptop with pgbench scale 1 (default), and then:
>
> pgbench -S -T 60
>
> master: tps = 8251.883229 (excluding connections establishing)
> patched: tps = 9556.836232 (excluding connections establishing)
>
> pgbench -S -T 60 -M prepared
>
> master: tps = 14713.821837 (excluding connections establishing)
> patched: tps = 16200.066185 (excluding connections establishing)
>
> So from that this seems like an easy win.
Well, that makes it look pretty good. If we can get 10-15% on some
machines without making things slower on any other machines, then that
seems like a good win to me.
Thanks for testing that.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-11-23 20:52:53 | walsender bug: stuck during shutdown |
| Previous Message | Alvaro Herrera | 2020-11-23 20:31:24 | Re: "as quickly as possible" (was: remove spurious CREATE INDEX CONCURRENTLY wait) |