Re: Make tuple deformation faster

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Victor Yegorov <vyegorov(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Make tuple deformation faster
Date: 2024-12-24 01:57:27
Message-ID: CAApHDvqpzWwDk3qjgiuz4uSmBM12LPvCrgna+aHNMoNMPGXF6A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 24 Dec 2024 at 11:19, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> The attached adjusts that Assert code so that a fresh CompactAttribute
> is populated instead of modifying the TupleDesc's one. I'm not sure
> if populate_compact_attribute_internal() is exactly the nicest way to
> do this. I'll think a bit harder about that. Assume the attached is
> POC grade.

I've now pushed a fix for this using the same method but with the code
factored around a little differently. I didn't want to expose the
populate_compact_attribute_internal() function externally, so I
invented verify_compact_attribute() to call from
TupleDescCompactAttr().

Thanks for the report.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yurii Rashkovskii 2024-12-24 03:42:49 Re: Add Postgres module info
Previous Message wenhui qiu 2024-12-24 01:55:09 Re: transaction lost when delete clog file after normal shutdown