From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, maxim(dot)boguk(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #17871: JIT during postgresql_fdw remote_estimates EXPLAIN have very negatively effect on planning time |
Date: | 2023-03-28 22:03:38 |
Message-ID: | CAApHDvqmRmfO4XSfuFpp0gv3bWsfKoZyABNRdmqurbnjsse_aQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Wed, 29 Mar 2023 at 07:33, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2023-03-28 16:05:00 +1300, David Rowley wrote:
> > I guess that means just add a check for EXEC_FLAG_EXPLAIN_ONLY in
> > jit_compile_expr, or only set the es_jit_flags bits in
> > standard_ExecutorStart() when not in EXEC_FLAG_EXPLAIN_ONLY. I'm not
> > really sure which of those is better, but the attached does the former
> > and seems to fix the issue.
>
> I'm a bit worried about either of these making EXPLAIN less informative. Right
> now we can see whether and how much would be JITed without ANALYZE. After this
> not anymore.
If you're worried about that, then wouldn't it just be better to do
something like have jit_compile_expr() increment some other counter
when bailing on EXEC_FLAG_EXPLAIN_ONLY then have EXPLAIN add that
counter to created_functions? With that, we don't need to invent any
new syntax and also remove the overhead from EXPLAIN and also keep the
JIT information.
David
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Regmi | 2023-03-29 04:24:20 | Re: NEED RPM FILE OF LATEST POSTGRE supported for AIX 7.2 |
Previous Message | Tom Lane | 2023-03-28 20:57:13 | Re: NEED RPM FILE OF LATEST POSTGRE supported for AIX 7.2 |