From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Executor code - found an instance of a WHILE that should just be an IF |
Date: | 2021-05-13 08:20:36 |
Message-ID: | CAApHDvqkeM39iNzVPBvN54jNQ3XR40G_sT+bcudeyODZwsfBmA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, 10 May 2021 at 23:49, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Mon, 10 May 2021 at 21:16, Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> > During debugging I noticed some code in ExecResult() where a WHILE
> > loop is being used with an unconditional RETURN at the end of the
> > block (which is intentional, looking at the history of changes), but
> > now there's no actual use of the loop in any way. The code should
> > probably be changed to just use IF for clarity.
> > I've attached a patch.
>
> Looks like leftovers from ea15e1867.
>
> I don't think this will affect any code generation but you are right,
> it should be an "if".
Since there's no bug fix here, I thought that there's not much point
in backpatching this.
Does anyone object to making this small change in master?
David
From | Date | Subject | |
---|---|---|---|
Next Message | torikoshia | 2021-05-13 08:23:33 | Re: RFC: Logging plan of the running query |
Previous Message | Etsuro Fujita | 2021-05-13 08:00:22 | Re: Inherited UPDATE/DELETE vs async execution |