Re: Add proper planner support for ORDER BY / DISTINCT aggregates

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pavel Luzanov <p(dot)luzanov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Subject: Re: Add proper planner support for ORDER BY / DISTINCT aggregates
Date: 2022-11-09 01:58:53
Message-ID: CAApHDvqiEBY5_fVv4ZwUtWDPk0pJ6TdoYKFMwhhF_Gdkv-xAkg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 8 Nov 2022 at 19:51, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> For unsorted paths, the original logic here is to explicitly add a Sort
> path only for the cheapest-total path. This patch changes that and may
> add a Sort path for other paths besides the cheapest-total path. I
> think this may introduce in some unnecessary path candidates.

Yeah, you're right. The patch shouldn't change that. I've adjusted
the attached patch so that part works more like it did before.

v2 attached.

Thanks

David

Attachment Content-Type Size
adjust_incremental_sort_costings_v2.patch text/plain 10.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2022-11-09 02:25:27 Re: Add connection active, idle time to pg_stat_activity
Previous Message Andres Freund 2022-11-09 01:56:14 Re: Add connection active, idle time to pg_stat_activity