| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A performance issue with Memoize |
| Date: | 2024-01-26 04:18:17 |
| Message-ID: | CAApHDvqgnhQfeHhUupNyRKAZip0CKUx_kg9ZaZ+DMWczJ1vM6Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 26 Jan 2024 at 16:51, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> However ... it seems like we're not out of the woods yet. Why
> >> is Richard's proposed test case still showing
> >> + -> Memoize (actual rows=5000 loops=N)
> >> + Cache Key: t1.two, t1.two
> >> Seems like there is missing de-duplication logic, or something.
>
> > This seems separate and isn't quite causing the same problems as what
> > Richard wants to fix so I didn't touch this for now.
>
> Fair enough, but I think it might be worth pursuing later.
Here's a patch for that.
David
| Attachment | Content-Type | Size |
|---|---|---|
| dont_produce_duplicate_memoize_keys.patch | text/plain | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | reid.thompson | 2024-01-26 04:23:51 | Re: Remove unused fields in ReorderBufferTupleBuf |
| Previous Message | Tom Lane | 2024-01-26 03:51:49 | Re: A performance issue with Memoize |