Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Masahiko Sawada <msawada(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p
Date: 2025-03-12 08:37:35
Message-ID: CAApHDvqf4tKwE0oP8ybL2Eu-SD=C34pdZ9vVDSJwvqDXi88nUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, 12 Mar 2025 at 21:15, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 12.03.25 03:08, David Rowley wrote:
> > This introduces a new compiler warning for compilers that don't know
> > the ereport(ERROR) does not return.
>
> Which compiler is that?

C:\Users\drowley\pg_src>cl
Microsoft (R) C/C++ Optimizing Compiler Version 19.43.34808 for x64
Copyright (C) Microsoft Corporation. All rights reserved.

I suspect drongo will also show the same warning once it runs on the
latest commit shortly.

David

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2025-03-12 09:41:43 Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Previous Message Peter Eisentraut 2025-03-12 08:15:15 Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p