From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Use generation context to speed up tuplesorts |
Date: | 2021-08-08 10:11:12 |
Message-ID: | CAApHDvqbEvhiw3DqxN-J_2YNYZ-TNeyCXcvURX1A68Lse3Gp3A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 7 Aug 2021 at 12:10, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
> > All of the tests show that the patches to improve the allocation
> > efficiency of generation.c don't help to improve the results of the
> > test cases. I wondered if it's maybe worth trying to see what happens
> > if instead of doubling the allocations each time, quadruple them
> > instead. I didn't try this.
> >
>
> I doubt quadrupling the allocations won't help very much, but I suspect
> the problem might be in the 0004 patch - at least that's what shows
> regression in my results. Could you try with just 0001-0003 applied?
I tried the quadrupling of the buffer instead of doubling it each time
and got the attached. Column E, or green in the graphs show the
results of that. It's now much closer to the original patch which just
made the block size 8MB.
David
Attachment | Content-Type | Size |
---|---|---|
generation context tuplesort_v2.ods | application/vnd.oasis.opendocument.spreadsheet | 75.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | tanghy.fnst@fujitsu.com | 2021-08-08 10:36:49 | RE: [PATCH] Add tab-complete for backslash commands |
Previous Message | vignesh C | 2021-08-08 09:34:09 | Re: [PATCH]Comment improvement in publication.sql |