Re: pgsql: Attempt to fix unstable regression tests, take 2

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowley(at)gmail(dot)com>, David Rowley <drowley(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Subject: Re: pgsql: Attempt to fix unstable regression tests, take 2
Date: 2020-04-01 00:33:33
Message-ID: CAApHDvqWMvyLsZuZ_Ej3sqgxN8qwNNx6j=uTbrpA6oURjGjOJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, 1 Apr 2020 at 13:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowley(at)gmail(dot)com> writes:
> > On Tue, 31 Mar 2020 at 15:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Now this *IS* autovacuum interference, but it's hardly autovacuum's fault:
> >> the test script is supposing that autovac won't come in before it does a
> >> manual analyze, and that's just unsafe on its face.
>
> > Why would that matter?
>
> Look again at the failure: the problem is that the test script is
> populating a table, then doing an EXPLAIN and expecting to see
> results corresponding to a *not*-ANALYZED table, then doing ANALYZE,
> then expecting to see EXPLAIN results corresponding to the analyzed
> state. It's the second step of that that is vulnerable to an
> ill-timed auto analyze. The only way to prevent it is to disable
> autovac altogether on the table, as I did a little while ago
> at 0936d1b6f.

Can you share which failure you're talking about here? All of the
ones I've looked at were failing post-ANALYZE.

David

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-04-01 00:40:59 Re: pgsql: Attempt to fix unstable regression tests, take 2
Previous Message Tom Lane 2020-03-31 23:59:57 Re: pgsql: Attempt to fix unstable regression tests, take 2