Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, joseph(dot)ayers(at)crunchydata(dot)com, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path
Date: 2020-11-25 01:46:12
Message-ID: CAApHDvqLTd-huxhTvFbgf_mOa3ND0bGhbpgX0m_i-py-MbWH-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 25 Nov 2020 at 14:35, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Wed, 25 Nov 2020 at 14:28, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > So maybe, rather than hacking up the attribute stuff for
> > a bug that might bite us again anyway in future, we ought
> > to press walleye's owner to install a more recent compiler.
>
> I think that seems like a better idea. I had thoughts about
> installing a quick for now to give the owner of walleye a bit of time
> for the upgrade. From what I can tell, the latest version of minGW
> comes with GCC 9.2 [1]

So, how about the attached today and I'll email Joseph about walleye
and see if he can upgrade to a newer minGW version.

David

Attachment Content-Type Size
pg_attribute_cold_fix_mingw.patch text/plain 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-11-25 01:47:42 Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path
Previous Message Tomas Vondra 2020-11-25 01:44:55 Re: [PoC] Non-volatile WAL buffer