Re: BTScanOpaqueData size slows down tests

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: BTScanOpaqueData size slows down tests
Date: 2025-04-02 22:26:08
Message-ID: CAApHDvqH+EY30So1tdGbF085q1Zj4gAjpE+b4-YC1WM7Vr2ARQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 3 Apr 2025 at 04:21, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I was mildly
> surprised to see how expensive the new compact attribute checks are.

Is this a fairly deform-heavy workload? FWIW, before adding that
Assert, I did test to see if there was any measurable impact on the
time it took to run all the tests [1] and I couldn't measure it. I
feel having something to check these are in sync is worthwhile. It did
find bugs during the development of the patch.

David

[1] https://postgr.es/m/CAApHDvpHmUuFY9rtRw6oiG7OTM-o%2BBnODg1m-EynKGbbhSsMzA%40mail.gmail.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2025-04-02 22:58:30 Re: Question -- why is there no errhint_internal function?
Previous Message Andres Freund 2025-04-02 22:17:35 Re: Some read stream improvements