| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: unrecognized node type while displaying a Path due to dangling pointer |
| Date: | 2023-07-12 02:50:15 |
| Message-ID: | CAApHDvqG5n+S4Ekbe6jPQZmyDehovLb_wh2jv2ixpZd7FX0HKg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 12 Jul 2023 at 14:23, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I did think about that, but "shallow copy a Path" seems nontrivial
> because the Path structs are all different sizes. Maybe it is worth
> building some infrastructure to support that?
It seems a reasonable thing to have to do. It seems the minimum thing
we could do to ensure each Path is only mentioned in at most 1
RelOptInfo.
I see GetExistingLocalJoinPath() in foreign.c might be related to this
problem, per:
> * If the inner or outer subpath of the chosen path is a ForeignScan, we
> * replace it with its outer subpath. For this reason, and also because the
> * planner might free the original path later, the path returned by this
> * function is a shallow copy of the original. There's no need to copy
> * the substructure, so we don't.
so that function could probably disappear if we had this.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Sewell | 2023-07-12 02:52:37 | Re: COPY table FROM STDIN via SPI |
| Previous Message | Tom Lane | 2023-07-12 02:37:09 | Re: Forgive trailing semicolons inside of config files |