| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, jeremyevans0(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17495: Regression in 15beta1 when filtering subquery including row_number window function |
| Date: | 2022-05-26 22:44:34 |
| Message-ID: | CAApHDvq8RQKX5UNDfkvGST_mKhmunzYO+SG_jpfta1uT+gjeoA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 26 May 2022 at 20:44, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> Another review comment:
>
> - * extra_used_attrs can passed as non-NULL to mark any columns that we should
> + * extra_used_attrs can be passed as non-NULL to mark any columns that we should
Thanks for the reviews.
Since the latest patch didn't require changing the WindowClause
struct, I saw no reason to delay fixing the bug. I've now pushed the
patch after doing a bit more work on the comments.
I also added the missing initialization of runCondition in
transformWindowDefinitions().
I am keen to devise some way of not having this feature scribble
anything on the WindowClause struct. I just think we need to come up
with some supplementary data structure that's not "Query" to write
these sorts of things down on. I'm thinking that's PG16 material now.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-05-27 00:00:23 | Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY |
| Previous Message | Tom Lane | 2022-05-26 21:35:13 | Re: Unable to connect to PostgreSQL DB as root user when private key is owned by root with permission 640 |