Re: "an SQL" vs. "a SQL"

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: "an SQL" vs. "a SQL"
Date: 2021-06-10 14:51:23
Message-ID: CAApHDvq44t7kN-_1oD2SkUK=aFb-cRpOvhRkVyNx=M=JZktaiQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 11 Jun 2021 at 02:35, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Jun-10, David Rowley wrote:
> > My regex foo is not strong enough to think how I might find multiline instances.
>
> This catches some of these:
>
> ag "\sa[\s*]*\n[\s*]*(A|E|F|H|I|L|M|N|O|S|X)[A-Z]{2,5}\s"

Thanks. I ended up using -C 1 and manually checking the previous line.

> You get a bunch of "a NULL" or "a NOT" and so on, but here's a few valid ones:
>
> contrib/tablefunc/tablefunc.c:316: * crosstab - create a crosstab of rowids and values columns from a
> contrib/tablefunc/tablefunc.c:317: * SQL statement returning one rowid column, one category column,
>
> contrib/tablefunc/tablefunc.c:607: * crosstab - create a crosstab of rowids and values columns from a
> contrib/tablefunc/tablefunc.c:608: * SQL statement returning one rowid column, one category column,
>
> doc/src/sgml/plpgsql.sgml
> 1127: The result of a
> 1128: SQL command yielding a single row (possibly of multiple
>
> src/backend/catalog/pg_subscription.c:438: * translator: first %s is a SQL ALTER command and second %s is a
> src/backend/catalog/pg_subscription.c:439: * SQL DROP command
>
> src/backend/replication/logical/logical.c:126: * 1) We need to be able to correctly and quickly identify the timeline a
> src/backend/replication/logical/logical.c:127: * LSN belongs to
>
> src/backend/libpq/auth.c:847: * has. If it's an MD5 hash, we must do MD5 authentication, and if it's a
> src/backend/libpq/auth.c:848: * SCRAM secret, we must do SCRAM authentication.

Thanks. I've left all the .c file comments alone for no and looks like
I got the doc/src/sgml/plpgsql.sgml one already.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-10 14:53:26 Re: "an SQL" vs. "a SQL"
Previous Message Isaac Morland 2021-06-10 14:48:11 Re: "an SQL" vs. "a SQL"