| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Making aggregate deserialization (and WAL receive) functions slightly faster |
| Date: | 2023-10-26 04:00:29 |
| Message-ID: | CAApHDvq3+qGTEcWzO+esGokirBpjX_AdtfqNOJu9WocbPcwtQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 26 Oct 2023 at 08:43, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I think that we can make that assumption starting with v17.
> Back-patching it would be hazardous perhaps; but if there's some
> function out there that depends on NUL termination, testing should
> expose it before too long. Wouldn't hurt to mention this explicitly
> as a possible incompatibility in the commit message.
>
> Looking over the v5 patch, I have some nits:
Thanks for looking at this again. I fixed up each of those and pushed
the result, mentioning the incompatibility in the commit message.
Now that that's done, I've attached a patch which makes use of the new
initReadOnlyStringInfo initializer function for the original case
mentioned when I opened this thread. I don't think there are any
remaining objections to this, but I'll let it sit for a bit to see.
David
| Attachment | Content-Type | Size |
|---|---|---|
| use_initReadOnlyStringInfo_more.patch | text/plain | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2023-10-26 04:07:35 | Re: A performance issue with Memoize |
| Previous Message | Alexander Lakhin | 2023-10-26 04:00:00 | Re: Is this a problem in GenericXLogFinish()? |