On Thu, 1 Jul 2021 at 02:58, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>
> On Wed, Jun 30, 2021 at 23:34 David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> + while ((rti = bms_next_member(checkPermRels, rti)) > 0)
>> {
>> - RangeTblEntry *rte = (RangeTblEntry *) lfirst(l);
>> + RangeTblEntry *rte = (RangeTblEntry *) list_nth(rangeTable, rti - 1);
>>
>> I'd have expected >= 0 rather than > 0.
>
> Hmm, a valid RT index cannot be 0, so that seems fine to me. Note that RT indexes are added as-is to that bitmapset, not after subtracting 1.
Oh, you're right. My mistake.
David