Re: pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Amit Langote <amitlan(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Prevent duplicate RTEPermissionInfo for plain-inheritance parent
Date: 2023-10-26 06:08:12
Message-ID: CAApHDvpjA_8Wxu4DCTRVAvPxC9atwMe6N+yvrcGsgb7mrfdpJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, 26 Oct 2023 at 15:59, Amit Langote <amitlan(at)postgresql(dot)org> wrote:
> src/backend/optimizer/util/inherit.c | 9 ++-------

Hi Amit,

I'm getting an unused variable warning from this with non-assert builds:

[697/1908] Compiling C object
src/backend/postgres_lib.a.p/optimizer_util_inherit.c.o
../src/backend/optimizer/util/inherit.c: In function
‘expand_single_inheritance_child’:
../src/backend/optimizer/util/inherit.c:460:33: warning: unused
variable ‘parentOID’ [-Wunused-variable]
460 | Oid parentOID = RelationGetRelid(parentrel);
| ^~~~~~~~~

Maybe parentOID needs a PG_USED_FOR_ASSERTS_ONLY?

David

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-10-26 07:29:37 pgsql: Add trailing commas to enum definitions
Previous Message David Rowley 2023-10-26 03:32:12 pgsql: Introduce the concept of read-only StringInfos