Re: Cleanup SubPlanstate

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleanup SubPlanstate
Date: 2024-10-31 00:49:29
Message-ID: CAApHDvpf0XQ_MMTuo6VVgBeAtEZX5XBZdLs6SezhawuTmvYwBQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 30 Oct 2024 at 03:34, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com> wrote:
> While reviewing a related patch, it came to the notice that tab_eq_funcs in the SubPlanState is not used. Hence the patch.

Thanks for picking that up. I didn't quite understand why you adjusted
the header comment for the TupleHashEntryData struct when the field
you removed was in the SubPlanState struct, so I left that part out.
However, I did fix the existing typo in that comment.

I've pushed the resulting patch.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2024-10-31 00:55:01 RE: Conflict detection for update_deleted in logical replication
Previous Message Michael Paquier 2024-10-31 00:32:16 Re: Interrupts vs signals